Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-140 & NETOBSERV-141 Top pod / service talkers #392

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1beta1/flowcollector_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,9 @@ type FLPMetrics struct {
Server MetricsServerConfig `json:"server,omitempty"`

// `ignoreTags` is a list of tags to specify which metrics to ignore. Each metric is associated with a list of tags. More details in https://github.com/netobserv/network-observability-operator/tree/main/controllers/flowlogspipeline/metrics_definitions .
// Available tags are: `egress`, `ingress`, `flows`, `bytes`, `packets`, `namespaces`, `nodes`, `workloads`, `nodes-flows`, `namespaces-flows`, `workloads-flows`.
// Available tags are: `egress`, `ingress`, `flows`, `bytes`, `packets`, `namespaces`, `nodes`, `workloads`, `pods`, `services`, `nodes-flows`, `namespaces-flows`, `workloads-flows`.
// Namespace-based metrics are covered by both `workloads` and `namespaces` tags, hence it is recommended to always ignore one of them (`workloads` offering a finer granularity).
//+kubebuilder:default:={"egress","packets","nodes-flows","namespaces-flows","workloads-flows","namespaces"}
//+kubebuilder:default:={"egress","packets","nodes-flows","namespaces-flows","workloads-flows","namespaces", "pods"}
// +optional
IgnoreTags []string `json:"ignoreTags"`

Expand Down
11 changes: 6 additions & 5 deletions bundle/manifests/flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4463,15 +4463,16 @@ spec:
- namespaces-flows
- workloads-flows
- namespaces
- pods
description: '`ignoreTags` is a list of tags to specify which
metrics to ignore. Each metric is associated with a list
of tags. More details in https://github.com/netobserv/network-observability-operator/tree/main/controllers/flowlogspipeline/metrics_definitions
. Available tags are: `egress`, `ingress`, `flows`, `bytes`,
`packets`, `namespaces`, `nodes`, `workloads`, `nodes-flows`,
`namespaces-flows`, `workloads-flows`. Namespace-based metrics
are covered by both `workloads` and `namespaces` tags, hence
it is recommended to always ignore one of them (`workloads`
offering a finer granularity).'
`packets`, `namespaces`, `nodes`, `workloads`, `pods`, `services`,
`nodes-flows`, `namespaces-flows`, `workloads-flows`. Namespace-based
metrics are covered by both `workloads` and `namespaces`
tags, hence it is recommended to always ignore one of them
(`workloads` offering a finer granularity).'
items:
type: string
type: array
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@ metadata:
"nodes-flows",
"namespaces-flows",
"workloads-flows",
"namespaces"
"namespaces",
"pods"
],
"server": {
"port": 9102
Expand Down
11 changes: 6 additions & 5 deletions config/crd/bases/flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4450,15 +4450,16 @@ spec:
- namespaces-flows
- workloads-flows
- namespaces
- pods
description: '`ignoreTags` is a list of tags to specify which
metrics to ignore. Each metric is associated with a list
of tags. More details in https://github.com/netobserv/network-observability-operator/tree/main/controllers/flowlogspipeline/metrics_definitions
. Available tags are: `egress`, `ingress`, `flows`, `bytes`,
`packets`, `namespaces`, `nodes`, `workloads`, `nodes-flows`,
`namespaces-flows`, `workloads-flows`. Namespace-based metrics
are covered by both `workloads` and `namespaces` tags, hence
it is recommended to always ignore one of them (`workloads`
offering a finer granularity).'
`packets`, `namespaces`, `nodes`, `workloads`, `pods`, `services`,
`nodes-flows`, `namespaces-flows`, `workloads-flows`. Namespace-based
metrics are covered by both `workloads` and `namespaces`
tags, hence it is recommended to always ignore one of them
(`workloads` offering a finer granularity).'
items:
type: string
type: array
Expand Down
1 change: 1 addition & 0 deletions config/samples/flows_v1beta1_flowcollector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ spec:
# Ignoring eihter "namespaces" or "workloads", as namespaces metrics are included in workload metrics
# This helps reduce total cardinality
- namespaces
- pods
disableAlerts: []
dropUnusedFields: true
resources:
Expand Down