net.minidev.json.parser.JSONParser.ACCEPT_TAILLING_DATA seems to have no effect

[jochenberger]

Trailing data is accepted regardless of what I set the net.minidev.json.parser.JSONParser.ACCEPT_TAILLING_DATA setting to. net.minidev.json.parser.JSONParserBase.checkTaillingData is initialized but never used.

[UrielCh]

ACCEPT_TAILLING_DATA is correcty functionnal.
if ACCEPT_TAILLING_DATA is not set JSONSmart will refused data but will accepte Spaces.

I have juste add an ACCEPT_TAILLING_SPACE, to solve your probleme

[UrielCh]

this feature look to be only available on json-smart 1.X and is not functionnal in 2.X...

[jochenberger]

if ACCEPT_TAILLING_DATA is not set JSONSmart will refused data but will accepte Spaces.

Yes, that's what json-smart 1.x used to do. 2.x accepts {"foo":"bar"}{ no matter what I set ACCEPT_TAILLING_DATA to.

[UrielCh]

I found the probleme...

[UrielCh]

Can you test the current trunk version, and let me know if the issue is fixed?

[jochenberger]

Looks good to me, thanks.

[UrielCh]

Finaly 2.0.1 won't be released, switch to version 2.1.0 available on maven central repo

[jochenberger]

No, it's not working properly, test case:

    public void testTaillingDataWithSpaceAllowed() throws Exception {
        String s = "{\"t\":0}{";
        MustThrows.testInvalidJson(s, JSONParser.MODE_STRICTEST | JSONParser.ACCEPT_TAILLING_SPACE, ParseException.ERROR_UNEXPECTED_TOKEN);
    }

[UrielCh]

I had juste add this test, and fix this side effect.

2014-10-20 9:25 GMT+02:00 jochenberger notifications@github.com:

No, it's not working properly, test case:

public void testTaillingDataWithSpaceAllowed() throws Exception {
    String s = "{\"t\":0}{";
    MustThrows.testInvalidJson(s, JSONParser.MODE_STRICTEST | JSONParser.ACCEPT_TAILLING_SPACE, ParseException.ERROR_UNEXPECTED_TOKEN);
}

—
Reply to this email directly or view it on GitHub
#1 (comment).

[UrielCh]

patched commited as non released version 1.3.2 and 2.1.1

2014-10-20 9:41 GMT+02:00 Uriel Chemouni uriel.chemouni@gmail.com:

I had juste add this test, and fix this side effect.

2014-10-20 9:25 GMT+02:00 jochenberger notifications@github.com:

No, it's not working properly, test case:

public void testTaillingDataWithSpaceAllowed() throws Exception {
    String s = "{\"t\":0}{";
    MustThrows.testInvalidJson(s, JSONParser.MODE_STRICTEST | JSONParser.ACCEPT_TAILLING_SPACE, ParseException.ERROR_UNEXPECTED_TOKEN);
}

—
Reply to this email directly or view it on GitHub
#1 (comment)
.