Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modernize Xcode project and testing #101

Merged
merged 10 commits into from
May 10, 2023
Merged

refactor: Modernize Xcode project and testing #101

merged 10 commits into from
May 10, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented May 10, 2023

New Pull Request Checklist

Issue Description

Project structure isn't modernized to current Xcode structure

Approach

  • Use SwiftUI app as TestHost
  • Use single ParseSwift target for all OS's in Xcode project
  • Remove Carthage from testing

TODOs before merging

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #101 (6d2fe3f) into main (519f222) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   91.60%   91.64%   +0.04%     
==========================================
  Files         172      172              
  Lines       15385    15385              
==========================================
+ Hits        14093    14100       +7     
+ Misses       1292     1285       -7     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query.swift 90.67% <100.00%> (ø)

... and 3 files with indirect coverage changes

@@ -1,6 +1,6 @@
//: [Previous](@previous)

//: For this page, make sure your build target is set to ParseSwift (macOS) and targeting
//: For this page, make sure your build target is set to ParseSwift and targeting

Check warning

Code scanning / Tailor (reported by Codacy)

Single-line comment should start with whitespace

Single-line comment should start with whitespace
@@ -1,6 +1,6 @@
//: [Previous](@previous)

//: For this page, make sure your build target is set to ParseSwift (macOS) and targeting
//: For this page, make sure your build target is set to ParseSwift and targeting

Check warning

Code scanning / Tailor (reported by Codacy)

Single-line comment should start with whitespace

Single-line comment should start with whitespace
@cbaker6 cbaker6 merged commit f110307 into main May 10, 2023
@cbaker6 cbaker6 deleted the relatedQuery branch May 10, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant