Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ambiguous SDK initializer #6

Merged
merged 4 commits into from
Oct 23, 2022
Merged

fix: ambiguous SDK initializer #6

merged 4 commits into from
Oct 23, 2022

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Oct 23, 2022

New Pull Request Checklist

Issue Description

Ambiguous initializer can cause build issues.

Approach

Updated signatures of SDK initializers.

TODOs before merging

  • Add tests
  • Add entry to changelog

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Merging #6 (fd500df) into main (c84b036) will decrease coverage by 2.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   90.42%   87.62%   -2.80%     
==========================================
  Files         161      161              
  Lines       16319    16277      -42     
==========================================
- Hits        14756    14263     -493     
- Misses       1563     2014     +451     
Impacted Files Coverage Δ
Sources/ParseSwift/Parse.swift 99.19% <100.00%> (ø)
Sources/ParseSwift/Types/ParseConfiguration.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 73.96% <0.00%> (-16.50%) ⬇️
Sources/ParseSwift/Objects/ParseInstallation.swift 74.44% <0.00%> (-11.97%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 77.62% <0.00%> (-10.52%) ⬇️
Sources/ParseSwift/Storage/ParseFileManager.swift 86.66% <0.00%> (-6.16%) ⬇️
...ources/ParseSwift/Storage/ParseKeyValueStore.swift 91.66% <0.00%> (-5.56%) ⬇️
Sources/ParseSwift/Types/ParseAnalytics.swift 90.74% <0.00%> (-1.45%) ⬇️
Sources/ParseSwift/Storage/KeychainStore.swift 95.44% <0.00%> (-1.14%) ⬇️
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 76.16% <0.00%> (-0.59%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 8c58ad2 into main Oct 23, 2022
@cbaker6 cbaker6 deleted the sdkInit branch October 23, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants