Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Storage access should wait until SDK initializes #65

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Mar 8, 2023

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

  • Add tests
  • Add entry to changelog

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #65 (e85db38) into main (16c9ec6) will decrease coverage by 0.04%.
The diff coverage is 79.06%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   90.48%   90.44%   -0.04%     
==========================================
  Files         166      166              
  Lines       14905    14942      +37     
==========================================
+ Hits        13487    13515      +28     
- Misses       1418     1427       +9     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 70.84% <56.75%> (-0.33%) ⬇️
Sources/ParseSwift/Types/ParseConfiguration.swift 96.96% <83.33%> (-3.04%) ⬇️
Sources/ParseSwift/Parse.swift 97.98% <92.85%> (+0.07%) ⬆️
Sources/ParseSwift/API/API.swift 99.40% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 88.31% <100.00%> (-0.02%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 90.79% <100.00%> (+0.01%) ⬆️
Sources/ParseSwift/Storage/ParseStorage.swift 83.87% <100.00%> (+1.72%) ⬆️
Sources/ParseSwift/Types/ParseConfig.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit ed55608 into main Mar 9, 2023
@cbaker6 cbaker6 deleted the fixInit branch March 9, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant