MDL-33878: Assignment - prevent error when removing overridden flag i…

…n gradebook This error only occurs when there is a submission but no grade in the assignment and the feedback comments plugin is enabled.
netspotau · Jun 20, 2012 · 14c46e2 · 14c46e2
1 parent e85b7e7
commit 14c46e2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php
@@ -3349,8 +3349,10 @@ public function get_user_grades_for_gradebook($userid) {
             // now get the feedback
             if ($gradebookplugin) {
                 $grade = $this->get_user_grade($result->userid, false);
-                $gradebookgrade->feedbacktext = $gradebookplugin->text_for_gradebook($grade);
-                $gradebookgrade->feedbackformat = $gradebookplugin->format_for_gradebook($grade);
+                if ($grade) {
+                    $gradebookgrade->feedbacktext = $gradebookplugin->text_for_gradebook($grade);
+                    $gradebookgrade->feedbackformat = $gradebookplugin->format_for_gradebook($grade);
+                }
             }
             $grades[$gradebookgrade->userid] = $gradebookgrade;
         }