FileStorage: always creates directories #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fprochazka
reviewed
Oct 6, 2016
| @@ -27,6 +27,8 @@ public function __construct($tempDir) | |||
|
|
|||
| public function loadConfiguration() | |||
| { | |||
| @mkdir($this->tempDir . '/cache'); // @ - directory may exists | |||
There was a problem hiding this comment.
Imho there should be a check for the return value and exception, no?
if (!@mkdir(...) && !is_dir(...)) throwThere was a problem hiding this comment.
FileStorage will throw exception.
dg
force-pushed
the
master
branch
3 times, most recently
from
492413c
to
b0b475e
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
6037e83
to
1fe69cc
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
1655c0f
to
7c885a2
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
0de58d2
to
29c60cc
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
0c6a125
to
59da4eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem with mkdir() and safe mode is outdated, isn't it?