[ContainerBuilder] getDefinitionByType() method added #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @dg |
|
What needs to be done here? |
|
Can it return NULL? |
|
Well, that was my first idea. But having What do you think? |
|
So annotation |
|
I see. That is leftover from 1st idea. Fixed! |
|
Great, thanks! |
|
Awesome, thanks a lot! |
|
For others, here are all use cases I used it in: deprecated-packages/symplify@1e8854c Requires |
dg
reviewed
May 2, 2017
| * Gets the service definition of the specified type. | ||
| * @param string | ||
| * @return ServiceDefinition|NULL | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All is described in the issue: #130
Behavior is compatible with with
getDefiniton()- exception is thrown when not found.This method is called in cases where Definition is required.