-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator: added support for enums #282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add a test? |
Added. |
UnitEnum has no value property. It has to be BackedEnum. |
Thanks for BackedEnum. |
This looks good, we might need this as well! Thanks @drobek94 , hope this will get merged |
Do I understand that the point is to use enums in addRule()? Have you tested it with JavaScript? |
Yes, it's working with JavaScript. And it's also necessary for setDefaults(). |
Thanks |
dg
pushed a commit
that referenced
this pull request
Mar 29, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 29, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 29, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 30, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 30, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 30, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 31, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Apr 3, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Apr 4, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Apr 18, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Apr 19, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Apr 27, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
May 3, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
May 4, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
May 4, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
May 4, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
May 4, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Dec 4, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Dec 5, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Dec 5, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Dec 27, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Dec 27, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Dec 27, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Dec 27, 2022
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 9, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 9, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 9, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jan 21, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 2, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 2, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 7, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 7, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 12, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Mar 12, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Jul 30, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Aug 5, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Oct 5, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
dg
pushed a commit
that referenced
this pull request
Oct 5, 2023
Co-authored-by: martin.sedlacek <martin.sedlacek@motv.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.