Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
BaseControl, SelectBox: labels and prompt are translated by global translator #58
This is just idea.
Error messages are since 6451fe0 translated by form's translator instead of control's one. It turned out to be the right decision. What about labels? I think that labels should be translated by form's translator too.
Maybe selectbox prompt too, but I am not sure.
referenced this pull request
Feb 7, 2015
I like the idea, but I suggest using overridable control's methods like
Alternatively there could be properties and public setters for both types of these translators (setItemsTranslator, setOuterTranslator) and the default behavior could again be the same as outlined above.