Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseControl, SelectBox: labels and prompt are translated by global translator #58

merged 1 commit into from Jun 21, 2017


Copy link

@dg dg commented Jan 29, 2015

This is just idea.

Error messages are since 6451fe0 translated by form's translator instead of control's one. It turned out to be the right decision. What about labels? I think that labels should be translated by form's translator too.

Maybe selectbox prompt too, but I am not sure.

Copy link

@JanTvrdik JanTvrdik commented Jan 30, 2015

So – what would the control's translator be for?

Copy link
Member Author

@dg dg commented Jan 30, 2015

setTranslator has sense for items on Choice & MultiChoiceControl.

@dg dg force-pushed the translator branch 2 times, most recently from 9303edc to 45e02e5 Compare Feb 6, 2015
@dg dg force-pushed the master branch 2 times, most recently from b644bbd to 3b543ff Compare Feb 6, 2015
Copy link

@solcik solcik commented Feb 7, 2015

I would very welcome this approach. Label and prompt via form's translator and items via control's. So It would not be needed to hack it - setTranslator(NULL) and then manually translate label and prompt.

@dg dg force-pushed the master branch 4 times, most recently from 75b0565 to 72a5c56 Compare Feb 8, 2015
Copy link

@Olicek Olicek commented Feb 9, 2015

Will this PR in Nette 2.3?

@dg dg added this to the v2.4 milestone Feb 16, 2015
@dg dg force-pushed the master branch 4 times, most recently from 164ee7d to 7b7189f Compare Feb 18, 2015
Copy link

@tomaswindsor tomaswindsor commented Apr 2, 2015

I like the idea, but I suggest using overridable control's methods like getOuterTranslator() and getItemsTranslator(), which would in their default implementation work as outlined above (getOuterTranslator() would return form's translator and getItemsTranslator() would return control's translator. Purpose is simply to make it possible to modify the behavior via inheritance.

Alternatively there could be properties and public setters for both types of these translators (setItemsTranslator, setOuterTranslator) and the default behavior could again be the same as outlined above.

Copy link

@zraly zraly commented Jan 14, 2017

So what is the result? It seems, that it is still not possible to translate control with form translator, but leave control items untranslated. Is that right? Because use case, when selectbox items are gathered from database is very common.

Copy link
Member Author

@dg dg commented Jan 16, 2017

I think it can be merged to 3.0-dev

@dg dg force-pushed the master branch 14 times, most recently from a6ec22a to c2c4dc3 Compare Jan 30, 2017
@dg dg force-pushed the master branch 2 times, most recently from 454e643 to a8c2e65 Compare Feb 2, 2017
@dg dg force-pushed the master branch 2 times, most recently from 571b36c to 841e5de Compare Mar 29, 2017
@dg dg merged commit 782b319 into nette:master Jun 21, 2017
1 of 2 checks passed
@dg dg deleted the translator branch Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

6 participants