Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckboxList: Add same options as RadioList #92

Merged
merged 1 commit into from Oct 12, 2015
Merged

CheckboxList: Add same options as RadioList #92

merged 1 commit into from Oct 12, 2015

Conversation

@enumag
Copy link
Contributor

enumag commented Aug 9, 2015

No description provided.

@enumag

This comment has been minimized.

Copy link
Contributor Author

enumag commented Aug 9, 2015

By the way some Latte related tests are failing for me on windows (unrelated to this PR).

Sorry, they pass with newer Latte (after composer update).

@matej21

This comment has been minimized.

Copy link
Contributor

matej21 commented Aug 9, 2015

see #79

@enumag

This comment has been minimized.

Copy link
Contributor Author

enumag commented Aug 9, 2015

@matej21 That doesn't cover everything from this PR though.

@dg

This comment has been minimized.

Copy link
Member

dg commented Aug 9, 2015

RadioList::$generateId exists only due to back compatiblity, it is not needed in CheckboxList.

@enumag enumag force-pushed the enumag:patch branch from ac82240 to c331f84 Aug 9, 2015
@enumag

This comment has been minimized.

Copy link
Contributor Author

enumag commented Aug 9, 2015

@dg Ok, removed.

@enumag

This comment has been minimized.

Copy link
Contributor Author

enumag commented Oct 12, 2015

bump

dg added a commit that referenced this pull request Oct 12, 2015
CheckboxList: Add same options as RadioList
@dg dg merged commit 469dc05 into nette:master Oct 12, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dg dg mentioned this pull request Oct 12, 2015
dg added a commit that referenced this pull request Oct 19, 2015
…Closes #92]"

This reverts commit e0bc505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.