Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckboxList: Add same options as RadioList #92

Merged
merged 1 commit into from
Oct 12, 2015
Merged

CheckboxList: Add same options as RadioList #92

merged 1 commit into from
Oct 12, 2015

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Aug 9, 2015

No description provided.

@enumag
Copy link
Contributor Author

enumag commented Aug 9, 2015

By the way some Latte related tests are failing for me on windows (unrelated to this PR).

Sorry, they pass with newer Latte (after composer update).

@matej21
Copy link
Contributor

matej21 commented Aug 9, 2015

see #79

@enumag
Copy link
Contributor Author

enumag commented Aug 9, 2015

@matej21 That doesn't cover everything from this PR though.

@dg
Copy link
Member

dg commented Aug 9, 2015

RadioList::$generateId exists only due to back compatiblity, it is not needed in CheckboxList.

@enumag
Copy link
Contributor Author

enumag commented Aug 9, 2015

@dg Ok, removed.

@enumag
Copy link
Contributor Author

enumag commented Oct 12, 2015

bump

dg added a commit that referenced this pull request Oct 12, 2015
@dg
Merge pull request #92 from enumag/patch
469dc05 
CheckboxList: Add same options as RadioList
@dg dg merged commit 469dc05 into nette:master Oct 12, 2015
dg pushed a commit that referenced this pull request Oct 12, 2015
@enumag @dg
CheckboxList: added containerPrototype and itemLabelPrototype [Closes #…
796858f 
…92]
dg pushed a commit that referenced this pull request Oct 12, 2015
@enumag @dg
CheckboxList: added containerPrototype and itemLabelPrototype [Closes #…
e0bc505 
…92]
@dg dg mentioned this pull request Oct 12, 2015
Closed
dg added a commit that referenced this pull request Oct 19, 2015
@dg
Revert "CheckboxList: added containerPrototype and itemLabelPrototype […
5e07a7b 
…Closes #92]"

This reverts commit e0bc505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enumag @matej21 @dg