Inline filters

[matej21]

Motivation:
Sometimes I need to apply the filter only on a part of macro arguments.

Current state:

{link default foo => $template->mod2($template->mod($name, 123))}

Proposal:

{link this slug => ($name|mod:123|mod2)}

You can also use inline filters on arguments of other filters

{$foo|replace:'foo':($replacement|lower)}

[dg]

BTW I tried it once implement this way:

    public function smartModifiersFilter(MacroTokens $tokens)
    {
        $inside = NULL;
        $brackets = array();
        $res = new MacroTokens;
        while ($tokens->nextToken()) {
            if ($tokens->isCurrent('(')) {
                $brackets[] = $res->position;

            } elseif ($tokens->isCurrent(')')) {
                if (array_pop($brackets) === $inside) {
                    $res->append(')');
                }

            } elseif ($tokens->isCurrent('|')) {
                if ($inside === end($brackets)) {
                    $res->append(')');
                }
                $name = $tokens->nextValue(MacroTokens::T_SYMBOL);
                if ($name === 'escape') {
                    $res = $this->escapeFilter($res, end($brackets));
                    $tokens->nextToken(')');
                    $inside = NULL;
                    continue;
                }

                $res->append('$template->' . $name . '(', end($brackets));
                $tokens->nextToken(',', ':');
                if ($tokens->isNext() && !$tokens->isNext(')', '|')) {
                    $res->append(',');
                }
                $inside = end($brackets);
                continue;

            } elseif ($tokens->isCurrent(':') && $inside === end($brackets)) {
                $res->append(',');
                continue;
            }

            $res->append($tokens->currentToken());
        }

        if ($inside !== NULL) {
            $res->append(')');
        }
        return $res;
    }

[foxycode]

👍

[matej21]

Could anyone test that regexp on windows? There are some issues and I think this regexp modification might make it even worse.

[matej21]

Could you please review it? I squashed it and I think it is ready :)

[dg]

Great, thanks!