TestCase: tearDown() is called even on error in test method [Closes #254

][Ref #255]

src/Framework/TestCase.php

@@ -105,10 +105,24 @@ public function runTest($method, array $args = NULL)
 			$data[] = $args;
 		}
 
+		$me = $this;
+		$errorHandler = function () use ($me, & $prev) {
+			restore_error_handler();
+			$rm = new \ReflectionMethod($me, 'tearDown');
+			$rm->setAccessible(TRUE);
+
+			set_error_handler(function () {}); // mute all errors
+			$rm->invoke($me);
+			restore_error_handler();
+
+			return $prev ? call_user_func_array($prev, func_get_args()) : FALSE;
+		};
+
 		foreach ($data as $params) {
 			try {
 				$this->setUp();
 
+				$prev = set_error_handler($errorHandler);
 				try {
 					if ($info['throws']) {
 						$tmp = $this;
@@ -123,6 +137,7 @@ public function runTest($method, array $args = NULL)
 					}
 				} catch (\Exception $testException) {
 				}
+				restore_error_handler();
 
 				try {
 					$this->tearDown();

tests/Framework/TestCase.order.error.phpt

@@ -0,0 +1,41 @@
+<?php
+
+/**
+ * @exitCode 255
+ * @outputMatch Test::setUp,Test::testMe,Test::tearDown,E_USER_ERROR: STOP%A%
+ */
+
+require __DIR__ . '/../bootstrap.php';
+
+Tester\Environment::$useColors = FALSE;
+
+
+class Test extends Tester\TestCase
+{
+	protected function setUp()
+	{
+		echo __METHOD__ . ',';
+	}
+
+	/** @dataProvider data */
+	public function testMe($arg)
+	{
+		echo __METHOD__ . ',';
+		trigger_error('STOP', E_USER_ERROR);
+	}
+
+	protected function tearDown()
+	{
+		echo __METHOD__ . ',';
+		trigger_error('NOT SHOWN', E_USER_ERROR);
+	}
+
+	protected function data()
+	{
+		return array(array('arg'));
+	}
+}
+
+
+$test = new Test;
+$test->run();