Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option fail-fast #110

Closed
hrach opened this issue Mar 7, 2014 · 9 comments
Closed

Option fail-fast #110

hrach opened this issue Mar 7, 2014 · 9 comments

Comments

@hrach
Copy link

hrach commented Mar 7, 2014

Sometimes if I implement new features, I need to fix tests. When there is more failed tests, it becomes quite messy, so I would like to use some option like fail-fast, which will run tests and stops when some fails.

@fprochazka
Copy link
Contributor

@hrach You can just CTRL+C (stop script) which outputs the summary and failure message for already runned tests.

@Majkl578
Copy link
Contributor

Majkl578 commented Mar 7, 2014

👎 for same reason as @fprochazka says. You can run single tests/directories already.

@hrach
Copy link
Author

hrach commented Mar 7, 2014

I'm not interested in running signle tests since it does not test regression. CTRL+C doesn't print failures.

@fprochazka
Copy link
Contributor

@hrach
Copy link
Author

hrach commented Mar 7, 2014

So the implementation is not the best.... :|
screenshot 2014-03-07 20 35 39

(Just note: I updated it earlier since I remembered that it was discussed, this update is just the prove ;))

@Majkl578
Copy link
Contributor

Majkl578 commented Mar 7, 2014

Do you have pcntl enabled by default for cgi? php-cgi -n -m | grep pcntl I see, Windows, so sad. :)

@milo
Copy link
Member

milo commented Mar 7, 2014

@hrach Ctrl+C works with pcntl extension only (Linux only afaik). There is a need to catch SIGINT signal.

Your propose seems good to me. I will work on Windows too and with --watch it can be used pretty comfortable.

@hrach
Copy link
Author

hrach commented Mar 7, 2014

http://cz1.php.net/manual/en/pcntl.installation.php
Currently, this module will not function on non-Unix platforms (Windows).

Also, as you can see, I also press ctrl+c for my purpose too late :)

@dg
Copy link
Member

dg commented Mar 8, 2014

👍 for propose. How to name the option?

@dg dg closed this as completed in 56fee6f Jun 6, 2014
dg added a commit that referenced this issue Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants