Show output from tests when process is killed via CTRL+C

[lm]

Runner now checks for SIGINT and after receiving signal invokes output handlers and returns.

[fprochazka]

I've tested it and it works flawlesly! Great work! 👍

$ ./tests/run.sh -j 5 ./tests/
PHP 5.5.7 | 'php-cgi' -n -c 'tests/php.ini-unix' | 5 threads

.......^C


OK (7 tests, 8.0 seconds)

[milo]

It is a good practice to add pcntl_signal(SIGINT, SIG_DFL); into handler body.

[milo]

And $this does not exists in closure in older PHP.

[lm]

I have added pcntl_signal(SIGINT, SIG_DFL); to the end of run() and removed $this from closure.

[fprochazka]

This is probably expected

$ ./tests/run.sh -j 5 ./tests/
PHP 5.5.7 | 'php-cgi' -n -c 'tests/php.ini-unix' | 5 threads

.......^CF

-- FAILED: ApiFoodController. | ApiFoodController.phpt ['testResponse']
   Exited with error code -1 (expected 0)


FAILURES! (8 tests, 1 failures, 8.1 seconds)

But the already running tests should be thrown away because they didn't in fact failed, they were killed.

[fprochazka]

@lm much better!

[lm]

Fixed (assessing of killed jobs).

[milo]

Why dispatch there? Would not already finished job pass?

[lm]

At this point it's not clear if job completed or was killed by signal, so is better to skip result check.

[milo]

Now I see.

[fprochazka]

@dg @milo ping?

Just FYI: I'm using it and it works flawlesly.

[milo]

I like it too. After traveling, I'll work on it.

[milo]

Merged 8021168

[hrach]

👍

[fprochazka]

Love it!