Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of ext-iconv #126

Closed
Cactucs opened this issue Nov 15, 2015 · 8 comments
Closed

Usage of ext-iconv #126

Cactucs opened this issue Nov 15, 2015 · 8 comments

Comments

@Cactucs
Copy link

@Cactucs Cactucs commented Nov 15, 2015

An unnecessary throws an error when ext-iconv not available.

Fatal error: Uncaught Error: Call to undefined function Tracy\iconv_strlen() in //vendor/tracy/tracy/src/Tracy/assets/Bar/info.panel.phtml:48
Stack trace:
#0 //vendor/tracy/tracy/src/Tracy/DefaultBarPanel.php(50): require()
#1 //vendor/tracy/tracy/src/Tracy/Bar.php(73): Tracy\DefaultBarPanel->getPanel()
#2 //vendor/tracy/tracy/src/Tracy/Debugger.php(207): Tracy\Bar->render()
#3 [internal function]: Tracy\Debugger::shutdownHandler()
#4 {main}
  thrown in //tracy/tracy/src/Tracy/assets/Bar/info.panel.phtml on line 48
@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Nov 30, 2015

Why unnecessary?

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

@JanTvrdik JanTvrdik commented Dec 3, 2015

Maybe he meant to say that Tracy should not require iconv extension?

@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Dec 3, 2015

Why should not?

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

@JanTvrdik JanTvrdik commented Dec 3, 2015

Because Tracy is low level library and should work in every environment? I don't know =)

@Cactucs

This comment has been minimized.

Copy link
Author

@Cactucs Cactucs commented Dec 4, 2015

Exactly

On Fri, Dec 4, 2015, 12:28 AM Jan Tvrdík notifications@github.com wrote:

Because Tracy is low level library and should work in every environment? I
don't know =)


Reply to this email directly or view it on GitHub
#126 (comment).

@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Dec 4, 2015

So fix it

dg added a commit that referenced this issue Jan 20, 2016
@dg dg closed this in a0a3d73 Jan 20, 2016
@Cactucs

This comment has been minimized.

Copy link
Author

@Cactucs Cactucs commented May 16, 2016

@dg

This comment has been minimized.

Copy link
Member

@dg dg commented May 16, 2016

Hahahaha :-) You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.