Filesystem::write() accept NULL in $mode parameter

[jkuchar]

• bug fix? yes
• new feature? no
• BC break? no (fixing unintended Nette 2.x BC break)

Code of function expects $mode to be NULL. If that happens it does not chmod it.

[dg]

It breaks compatibility with PHP 7.0

[dg]

Ping @jkuchar

[jkuchar]

Not sure how to write php doc here as you usually do not use @param with $variableName.

[JanTvrdik]

Most importantly you switched parameter name with parameter type, the annotation should be @param int|NULL $mode

[jkuchar]

I usually use assert when there is no possibility of declaring type using typehint (union types, ...) Do you like it or should it fail at line 144

[JanTvrdik]

Seems unnecessary to me.

[jkuchar]

@JanTvrdik thanks for review, updated

[jkuchar]

It does not look obvious what this parameter does... Is that creation mode or does it override current file mode?

Maybe add to docs something like:

• Alters file mode to given value (does not matter if file already or will be created exists)

Shouldn't NULL be the default value? created follow up in #140 and PR #141

[JanTvrdik]

There should be two spaces after @param to align with @return and @throws.

[jkuchar]

@JanTvrdik Should I squash this, have you finished review?

[jkuchar]

@JanTvrdik Added the same fix also for createDir() e5ecd37 Anything more that needs to be fixed?

[JanTvrdik]

@jkuchar Hopefully not.

[dg]

How differs mkdir($dir, 0777) from mkdir($dir, NULL)?

[jkuchar]

TL;DR: @dg you are right. NULL should be prohibited as it is evaluated to 0000 permission. Good catch! Interesting is that when mkdir is called with 0777 it is ignored and creates directory with default directory permissions. (is that somehow related to umask?)

I have performed the following test.

mkdir("testFromPHPNULL", NULL);
mkdir("testFromPHP0777", 0777);
exec("mkdir -m 0777 testFromBash0777");
exec("mkdir testFromBashDefault");

Tried this obscure situation with ACLs:

$ getfacl .                                 
# file: .
# owner: jkuchar1a
# group: domain^users
user::rwx
group::r-x                      #effective:---
mask::---
other::---
default:user::rwx
default:group::r-x              #effective:---
default:mask::---
default:other::---

$ ll
drwx------+  2 jkuchar1a domain^users 4096 čen  9 19:40 testFromBashDefault/
drwx------+  2 jkuchar1a domain^users 4096 čen  9 19:40 testFromBash0777/
d---------+  2 jkuchar1a domain^users 4096 čen  9 19:40 testFromPHPNULL/  <--- WRONG
drwx------+  2 jkuchar1a domain^users 4096 čen  9 19:40 testFromPHP0777/

Result permissions on testFromBashDefault and testFromPHP0777 are the same.

When no ACLs are used it behaves the same.

$ ll
drwxr-xr-x  2 jkuchar1a domain^users 4096 čen  9 19:46 ./
drwxr-xr-x 12 jkuchar1a domain^users 4096 čen  9 19:26 ../

drwxr-xr-x  2 jkuchar1a domain^users 4096 čen  9 19:50 testFromBashDefault/
drwxrwxrwx  2 jkuchar1a domain^users 4096 čen  9 19:50 testFromBash0777/ <--- WRONG
d---------  2 jkuchar1a domain^users 4096 čen  9 19:50 testFromPHPNULL/ <--- WRONG
drwxr-xr-x  2 jkuchar1a domain^users 4096 čen  9 19:50 testFromPHP0777/

[dg]

Thanks