Change API of Http3RequestStreamInboundHandler to better handle FIN #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 5740c52 introduced a workaround for correctly handle FIN when multiple http3 frames are contained in one QUIC frame. While this worked it was kind of hacky and we should better adjust the API. Modifications: - Change Http3RequestStreamInboundHandler API for handling frames and FIN - Adjust tests. Result: Better fix for handling multiple frames
|
@yawkat WDYT ? |
yawkat
approved these changes
Aug 30, 2023
| } else { | ||
| ctx.fireChannelRead(new DefaultHttpContent(frame.content())); | ||
| protected void channelRead(ChannelHandlerContext ctx, Http3DataFrame frame) throws Exception { | ||
| inboundTranslationInProgress = true; |
There was a problem hiding this comment.
can this be hit without a Http3HeadersFrame that already set this flag?
There was a problem hiding this comment.
this should never happen as a header frame must be sent first (which is validated by the frame decoder etc)
yeah... that said I think its most likely not a big deal and the API / implementation seems a bit better this way. |
|
@yawkat btw I am happy if you have any better idea :) |
|
i don't :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
5740c52 introduced a workaround for correctly handle FIN when multiple http3 frames are contained in one QUIC frame. While this worked it was kind of hacky and we should better adjust the API.
Modifications:
Result:
Better fix for handling multiple frames