Rename method to be less missleading (#44)

Motivation: Currently the method name is quite missleading, let's fix this. Modifications: Rename setSenderPrivateKey(...) to setPrivateKey(...) Result: Less missleading method name
netty · Jan 14, 2024 · 753b948 · 753b948
1 parent f06342f
commit 753b948
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpCryptoReceiver.java b/codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpCryptoReceiver.java
@@ -56,7 +56,7 @@ public Builder setConfiguration(OHttpCryptoConfiguration configuration) {
             return this;
         }
 
-        public Builder setSenderPrivateKey(AsymmetricCipherKeyPair privateKey) {
+        public Builder setPrivateKey(AsymmetricCipherKeyPair privateKey) {
             this.privateKey = privateKey;
             return this;
         }

diff --git a/codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpServerCodec.java b/codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpServerCodec.java
@@ -286,7 +286,7 @@ public boolean decodePrefix(ByteBufAllocator alloc, ByteBuf in) {
             receiver = OHttpCryptoReceiver.newBuilder()
                     .setOHttpCryptoProvider(provider)
                     .setConfiguration(version())
-                    .setSenderPrivateKey(keys.getKeyPair(ciphersuite))
+                    .setPrivateKey(keys.getKeyPair(ciphersuite))
                     .setCiphersuite(ciphersuite)
                     .setEncapsulatedKey(encapsulatedKey)
                     .build();

diff --git a/codec-ohttp/src/test/java/io/netty/incubator/codec/ohttp/OHttpCryptoTest.java b/codec-ohttp/src/test/java/io/netty/incubator/codec/ohttp/OHttpCryptoTest.java
@@ -168,7 +168,7 @@ public void testCryptoVectors(OHttpCryptoProvider senderProvider, OHttpCryptoPro
                 try (OHttpCryptoReceiver receiver = OHttpCryptoReceiver.newBuilder()
                         .setOHttpCryptoProvider(receiverProvider)
                         .setConfiguration(OHttpVersionDraft.INSTANCE)
-                        .setSenderPrivateKey(serverKeys.getKeyPair(ciphersuite))
+                        .setPrivateKey(serverKeys.getKeyPair(ciphersuite))
                         .setCiphersuite(receiverCiphersuite)
                         .setEncapsulatedKey(receiverEncapsulatedKey)
                         .setForcedResponseNonce(ByteBufUtil.decodeHexDump("c789e7151fcba46158ca84b04464910d"))