Add OHttpCryptoProvider.newRandomPrivateKey(...) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
commented
Dec 27, 2023
...rc/main/java/io/netty/incubator/codec/hpke/bouncycastle/BouncyCastleOHttpCryptoProvider.java
Outdated
Show resolved
Hide resolved
Motivation: Sometimes its useful to generate a new random key, we should allow to do this via method on the OHttpCryptoProvider interface. Modifications: Add OHttpCryptoProvider.newRandomPrivateKey(...) and add an implementation for BoringSSL and BouncyCastle Result: Be able to easily generate a new random key.
normanmaurer
force-pushed
the
generate
branch
from
f4600c8
to
403373a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes its useful to generate a new random key, we should allow to do this via method on the OHttpCryptoProvider interface.
Modifications:
Add OHttpCryptoProvider.newRandomPrivateKey(...) and add an implementation for BoringSSL and BouncyCastle
Result:
Be able to easily generate a new random key.