Simplify API for users and also simplify internal usage #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: How the user was suposed to use the OHttp*Codec was more complicated then needed. We can simplify things a lot by merging some classes and only expose things to the enduser that really matters. Modifications: - Merge serializer and parser - Make OHttpClientCodec non abstract and just let the user pass in a Function - Simplify both codecs Result: Simpler API
|
@thomdev PTAL |
thomdev
reviewed
Dec 6, 2023
codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpRequestResponseContext.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
How the user was suposed to use the OHttp*Codec was more complicated then needed. We can simplify things a lot by merging some classes and only expose things to the enduser that really matters.
Modifications:
Result:
Simpler API