Correctly use jlong and jint in native function definition to fix pos… #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible segfault Motivation: Due a bug we used long and int in the function definition while it must be jlong and jint. The problem is that jlong may not be the same "size" as long and so using the wrong type may result in truncating of the value. In this case we would use the wrong value as pointer and then crash. While the crashes were only observed on the CI on windows the reality is that it can happen basically everywhere. Long story short: the 'j' matters ... Modifications: Use jlong and jint Result: Fixes native crashes
|
Let me just hide in the woods for the rest of my life ... 🤦 |
chrisvest
approved these changes
Jul 28, 2021
Just make sure it is JWoods though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sible segfault
Motivation:
Due a bug we used long and int in the function definition while it must be jlong and jint. The problem is that jlong may not be the same "size" as long and so using the wrong type may result in truncating of the value. In this case we would use the wrong value as pointer and then crash.
While the crashes were only observed on the CI on windows the reality is that it can happen basically everywhere. Long story short: the 'j' matters ...
Modifications:
Use jlong and jint
Result:
Fixes native crashes