Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest boringssl chromium-stable commit #570

Merged
merged 2 commits into from Sep 5, 2023
Merged

Conversation

normanmaurer
Copy link
Member

Motivation:

There were updates to the chromium-stable branch of boringssl.

Modifications:

Update to latest sha

Result:

Use more recent boringssl version

Motivation:

There were updates to the chromium-stable branch of boringssl.

Modifications:

Update to latest sha

Result:

Use more recent boringssl version
@normanmaurer
Copy link
Member Author

@davidben I am correct that we should just remove -DOPENSSL_C11_ATOMIC these days ?

@davidben
Copy link

davidben commented Sep 5, 2023

I am correct that we should just remove -DOPENSSL_C11_ATOMIC these days ?

Yup! We no longer have a lock-based fallback and (more or less) require C11 (distressing how long it takes for a 12 year old standard to reach baseline), so if it builds, the atomics worked out. No need to specifically ask for them.

@normanmaurer normanmaurer merged commit ec495a1 into main Sep 5, 2023
12 checks passed
@normanmaurer normanmaurer deleted the boring_up branch September 5, 2023 15:32
@normanmaurer normanmaurer added this to the 0.0.51.Final milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants