Fix bug related to memoryAddress access when unsafe is not accessible… #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Datagram extension is used Motivation: We can't assume we can directly access the memoryAddress of the ByteBuf as it might not be possible on all platforms or even explicit disabled by the end user Modifications: Use static helper method that will always be able to return the correct memory address Result: Code works as expected on all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and Datagram extension is used
Motivation:
We can't assume we can directly access the memoryAddress of the ByteBuf as it might not be possible on all platforms or even explicit disabled by the end user
Modifications:
Use static helper method that will always be able to return the correct memory address
Result:
Code works as expected on all platforms