Only try to find index for QUIC packets with short header format #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
short_header_only
branch
from
8e46225
to
b03b135
Compare
Motivation: 28ae7d2 added the QuicCodecDispatcher which will dispatch packets to the correct ChannelHandlerContext based on which id is encoded in destination connection id. Our implementation was not 100 % correct as it should only try to do the specific dispatching once a short header format was used. Modifications: - Only try to decode the index out of the connection id for QUIC packets with short header format - Ensure we always correctly propagate channelReadComplete(...) even if we did not find the index. - Adjust testing Result: Correct dispatching based on destination connection id
normanmaurer
force-pushed
the
short_header_only
branch
from
b03b135
to
d8ce9d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
28ae7d2 added the QuicCodecDispatcher which will dispatch packets to the correct ChannelHandlerContext based on which id is encoded in destination connection id. Our implementation was not 100 % correct as it should only try to do the specific dispatching once a short header format was used.
Modifications:
Result:
Correct dispatching based on destination connection id