Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to retrieve the number of handshakes for a ssl instance #38

Closed
wants to merge 1 commit into from

Conversation

normanmaurer
Copy link
Member

Motivation:

To allow rejection client initiated renegotiations we need a way to obtain the number of previous done renegations.

Modifications:

Add SSL.getRenegations(...).

Result:

It's now possible to obtain the number of renegations.

@normanmaurer
Copy link
Member Author

@trustin please review

@normanmaurer normanmaurer self-assigned this May 5, 2015
@normanmaurer normanmaurer added this to the 1.1.33-Fork2 milestone May 5, 2015
@trustin
Copy link
Member

trustin commented May 6, 2015

I guess ctx->renegotiation in increased on the first successful handshake as well as renegotiations. Correct? If so, how about renaming renegotiation to handshakeCount and getRenegotiations() to getHandshakeCount()?

@normanmaurer
Copy link
Member Author

@trustin yes... Let me do this. And then cherry-pick.

Motivation:

To allow rejection client initiated renegotiations we need a way to obtain the number of previous done handshakes.

Modifications:

Add SSL.getHandshakeCount(...).

Result:

It's now possible to obtain the number of handshakes.
@normanmaurer normanmaurer force-pushed the reject_client_initiated_renegotiation branch from 8646882 to 374eb59 Compare May 6, 2015 06:15
@normanmaurer normanmaurer deleted the reject_client_initiated_renegotiation branch May 6, 2015 06:16
@normanmaurer
Copy link
Member Author

Cherry-picked into 1.1.33 as 1cd4832

@normanmaurer normanmaurer changed the title Allow to retrieve the number of renegations for a ssl instance Allow to retrieve the number of handshakes for a ssl instance May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants