Don't share tcn_ssl_verify_config_t between tcn_ssl_state_t and tcn_s… #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sl_ctxt_t Motivation: Let's not share the same memory between tcn_ssl_state_t and tcn_ssl_ctxt_t as it makes lifetime handling of the memory and prone to segfaults Modifications: - Let tcn_ssl_state_t contain tcn_ssl_verify_config_t and copy over the config from the tcn_ssl_ctxt_t if needed. - Remove free calls that are not needed anymore Result: Fix possible lifetime issue
chrisvest
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sl_ctxt_t
Motivation:
Let's not share the same memory between tcn_ssl_state_t and tcn_ssl_ctxt_t as it makes lifetime handling of the memory and prone to segfaults
Modifications:
Result:
Fix possible lifetime issue