Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Add PooledSlicedByteBuf and PooledDuplicatedByteBuf"
Motivation: Currently the "derived" buffer will only ever be recycled if the release call is made on the "derived" object, and the "wrapped" buffer ends up being "fully released" (aka refcount goes to 0). From my experience this is not the common use case and thus the "derived" buffers will not be recycled. Modifications: - revert #3788 Result: Less complexity, and less code to create new objects in majority of cases.
- Loading branch information
1 parent
99f701f
commit 77ff24b
Showing
6 changed files
with
8 additions
and
162 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 0 additions & 56 deletions
56
buffer/src/main/java/io/netty/buffer/PooledDuplicatedByteBuf.java
This file was deleted.
Oops, something went wrong.
56 changes: 0 additions & 56 deletions
56
buffer/src/main/java/io/netty/buffer/PooledSlicedByteBuf.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters