Skip to content

Commit

Permalink
Skip revapi check for the microbench (#12718)
Browse files Browse the repository at this point in the history
Motivation:
We should be able to evolve and change our benchmark code and infrastructure without worrying about compatibility.

Modification:
Skip revapi check for the microbench module and remove benchmarking specific configuration from the revapi plugin.

Result:
The microbench module is no longer subject to compatibility checks.

Co-authored-by: ahadadi <ahadadi@outbrain.com>
  • Loading branch information
amirhadadi and ahadadi committed Aug 18, 2022
1 parent b6b4584 commit b7ecda0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
1 change: 1 addition & 0 deletions microbench/pom.xml
Expand Up @@ -39,6 +39,7 @@
code -->
<kqueue.classifier />
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<javaModuleName>io.netty.microbench</javaModuleName>
</properties>
<profiles>
Expand Down
11 changes: 0 additions & 11 deletions pom.xml
Expand Up @@ -1087,10 +1087,6 @@
<matcher>java-package</matcher>
<match>/.*\.internal\..*/</match>
</item>
<item>
<matcher>java-package</matcher>
<match>/io\.netty\.microbench\..*/</match>
</item>
<item>
<matcher>java-package</matcher>
<match>/org\.openjdk\.jmh\..*/</match>
Expand Down Expand Up @@ -1130,13 +1126,6 @@
<package>io\.netty\..*</package>
<justification>They're not "external classes" if they're from a Netty package.</justification>
</item>
<item>
<ignore>true</ignore>
<code>java.class.removed</code>
<regex>true</regex>
<package>.*\.generated($|\..+)</package>
<justification>Ignore all classes generated by JMH.</justification>
</item>
<item>
<ignore>true</ignore>
<code>java.field.removed</code>
Expand Down

0 comments on commit b7ecda0

Please sign in to comment.