Skip to content

Commit

Permalink
Enforce a release is made with JDK 1.7 (and not w/ 1.8+)
Browse files Browse the repository at this point in the history
Motivations:

JDK 1.8 adds default methods to collections classes that reference
classes that don't exist in JDK 7. That's binary compatible,
but not source compatible.

Modifications:

Enforce JDK version to be 1.7.* when releasing

Result:

Fixes #3548
  • Loading branch information
trustin committed Mar 29, 2015
1 parent ab74dcc commit bdf0bdd
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions pom.xml
Expand Up @@ -216,6 +216,11 @@
</goals>
<configuration>
<rules>
<requireJavaVersion>
<!-- Enforce JDK 1.7 (and not 1.8+) for compilation. -->
<!-- See: https://github.com/netty/netty/issues/3548 -->
<version>[1.7.0, 1.8.0)</version>
</requireJavaVersion>
<requireProperty>
<regexMessage>
Release process must be performed on linux-x86_64.
Expand Down Expand Up @@ -877,8 +882,8 @@
<configuration>
<rules>
<requireJavaVersion>
<!-- Enforce java 1.7 as minimum for compiling -->
<!-- This is needed because of java.util.zip.Deflater and NIO UDP multicast-->
<!-- Enforce JDK 1.7+ for compilation. -->
<!-- This is needed because of java.util.zip.Deflater and NIO UDP multicast. -->
<version>[1.7.0,)</version>
</requireJavaVersion>
<requireMavenVersion>
Expand Down

0 comments on commit bdf0bdd

Please sign in to comment.