[HttpObjectDecoder] Include hex-value of illegal whitespace char #11067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpObjectDecoder may throw an IllegalArgumentException if it encounters a character that Character.isWhitespace() returns true for, but is not one of the two valid OWS (optional whitespace) values. Such values may not have friendly or readable toString() values. We should include the hex value so that the illegal character can always be determined.
normanmaurer
pushed a commit
that referenced
this pull request
Mar 9, 2021
) Motivation: HttpObjectDecoder may throw an IllegalArgumentException if it encounters a character that Character.isWhitespace() returns true for, but is not one of the two valid OWS (optional whitespace) values. Such values may not have friendly or readable toString() values. We should include the hex value so that the illegal character can always be determined. Modifications: Add hex value as well Result: Easier to debug Co-authored-by: Bennett Lynch <Bennett-Lynch@users.noreply.github.com>
This was referenced Mar 10, 2021
Merged
Merged
kodiakhq bot
pushed a commit
to shiruka/shiruka
that referenced
this pull request
Mar 10, 2021
Bumps [netty-all](https://github.com/netty/netty) from 4.1.59.Final to 4.1.60.Final. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/netty/netty/commit/eef26e8bb571612b76235841a84f605b9ae5d777"><code>eef26e8</code></a> [maven-release-plugin] prepare release netty-4.1.60.Final</li> <li><a href="https://github.com/netty/netty/commit/23ff30c40f3420345567191849c3abac284eb4d7"><code>23ff30c</code></a> Try to stabilize docker build by using https (<a href="https://github.com/netty/netty/issues/11070">#11070</a>)</li> <li><a href="https://github.com/netty/netty/commit/b8d843757b6291e32e920c0ce9c00d505c4e62f0"><code>b8d8437</code></a> [maven-release-plugin] rollback the release of netty-4.1.60.Final</li> <li><a href="https://github.com/netty/netty/commit/4f099dd11fa3d1c9f4963a72a0f72f4809c1459b"><code>4f099dd</code></a> [maven-release-plugin] prepare for next development iteration</li> <li><a href="https://github.com/netty/netty/commit/44e392e8512cce870d9b00da346e119f6323591e"><code>44e392e</code></a> [maven-release-plugin] prepare release netty-4.1.60.Final</li> <li><a href="https://github.com/netty/netty/commit/89c241e3b1795ff257af4ad6eadc616cb2fb3dc4"><code>89c241e</code></a> Merge pull request from GHSA-wm47-8v5p-wjpj</li> <li><a href="https://github.com/netty/netty/commit/bf9b90c3402683099b6da0e07fd55a4cebd21895"><code>bf9b90c</code></a> [HttpObjectDecoder] Include hex-value of illegal whitespace char (<a href="https://github.com/netty/netty/issues/11067">#11067</a>)</li> <li><a href="https://github.com/netty/netty/commit/4f498709d49de63872118fbbea0ba305feac0f03"><code>4f49870</code></a> Always include the OS in the tcnative library name (<a href="https://github.com/netty/netty/issues/11064">#11064</a>)</li> <li><a href="https://github.com/netty/netty/commit/0f12472b580bcbb34cbe84810077aa33c1091d14"><code>0f12472</code></a> Allow to config dns bind address in DnsNameResolver (<a href="https://github.com/netty/netty/issues/11061">#11061</a>)</li> <li><a href="https://github.com/netty/netty/commit/7d4aaa268b8a536f61fbc7711365147c58238745"><code>7d4aaa2</code></a> Support session cache for client and server when using native SSLEngine imple...</li> <li>Additional commits viewable in <a href="https://github.com/netty/netty/compare/netty-4.1.59.Final...netty-4.1.60.Final">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…ty#11067) Motivation: HttpObjectDecoder may throw an IllegalArgumentException if it encounters a character that Character.isWhitespace() returns true for, but is not one of the two valid OWS (optional whitespace) values. Such values may not have friendly or readable toString() values. We should include the hex value so that the illegal character can always be determined. Modifications: Add hex value as well Result: Easier to debug Co-authored-by: Bennett Lynch <Bennett-Lynch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpObjectDecodermay throw anIllegalArgumentExceptionif it encounters a character thatCharacter.isWhitespace()returnstruefor, but is not one of the two validOWS(optional whitespace) values. Such values may not have friendly or readabletoString()values. We should include the hex value so that the illegal character can always be determined.