Swap equals method call in SelfSignedCertificate #11896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xingrufei <rufeixing@tencent.com>
chrisvest
approved these changes
Dec 7, 2021
|
Thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Dec 7, 2021
Motivation: Users may set the algorithm in the constructor of `SelfSignedCertificate`, and need to swap `equalsIgnoreCase` method to call in `SelfSignedCertificate`,can avoid throwing `NullPointerException` Modification: Swap `equalsIgnoreCase` method to call in `SelfSignedCertificate` Result: `SelfSignedCertificate` will not throw NullPointerException Signed-off-by: xingrufei <rufeixing@tencent.com>
|
@normanmaurer It is my pleasure |
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: Users may set the algorithm in the constructor of `SelfSignedCertificate`, and need to swap `equalsIgnoreCase` method to call in `SelfSignedCertificate`,can avoid throwing `NullPointerException` Modification: Swap `equalsIgnoreCase` method to call in `SelfSignedCertificate` Result: `SelfSignedCertificate` will not throw NullPointerException Signed-off-by: xingrufei <rufeixing@tencent.com>
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: Users may set the algorithm in the constructor of `SelfSignedCertificate`, and need to swap `equalsIgnoreCase` method to call in `SelfSignedCertificate`,can avoid throwing `NullPointerException` Modification: Swap `equalsIgnoreCase` method to call in `SelfSignedCertificate` Result: `SelfSignedCertificate` will not throw NullPointerException Signed-off-by: xingrufei <rufeixing@tencent.com>
10brothers
pushed a commit
to 10brothers/netty
that referenced
this pull request
Jan 20, 2022
Motivation: Users may set the algorithm in the constructor of `SelfSignedCertificate`, and need to swap `equalsIgnoreCase` method to call in `SelfSignedCertificate`,can avoid throwing `NullPointerException` Modification: Swap `equalsIgnoreCase` method to call in `SelfSignedCertificate` Result: `SelfSignedCertificate` will not throw NullPointerException Signed-off-by: xingrufei <rufeixing@tencent.com>
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: Users may set the algorithm in the constructor of `SelfSignedCertificate`, and need to swap `equalsIgnoreCase` method to call in `SelfSignedCertificate`,can avoid throwing `NullPointerException` Modification: Swap `equalsIgnoreCase` method to call in `SelfSignedCertificate` Result: `SelfSignedCertificate` will not throw NullPointerException Signed-off-by: xingrufei <rufeixing@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Users may set the algorithm in the constructor of
SelfSignedCertificate, and need to swapequalsIgnoreCasemethod to call inSelfSignedCertificate,can avoid throwingNullPointerExceptionModification:
Swap
equalsIgnoreCasemethod to call inSelfSignedCertificateResult:
SelfSignedCertificatewill not throw NullPointerException