Cope with misbehaving Http2Headers implementations #12289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
requested changes
Apr 6, 2022
codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
Outdated
Show resolved
Hide resolved
Motivation: Some integrators may choose to use custom `Http2Headers` implementations, and might not implement all methods, or might not anticipate the ways in which we'll use the methods. For instance, this was a problem that affected GRPC. Modification: To cope with this, we guard our newly added call to `Http2Headers.contains()` call with an `instanceof` check to see if we're familiar with the implementation, and fall back to checking the direct accessor methods if not. Result: Avoid breaking those who wish to use old versions of GRPC with newer versions of Netty, or situations like that.
|
@normanmaurer How about this? |
normanmaurer
approved these changes
Apr 6, 2022
chrisvest
added a commit
that referenced
this pull request
Apr 6, 2022
Motivation: Some integrators may choose to use custom `Http2Headers` implementations, and might not implement all methods, or might not anticipate the ways in which we'll use the methods. For instance, this was a problem that affected GRPC. Modification: To cope with this, we guard our newly added call to `Http2Headers.contains()` call with an `instanceof` check to see if we're familiar with the implementation, and fall back to checking the direct accessor methods if not. Result: Avoid breaking those who wish to use old versions of GRPC with newer versions of Netty, or situations like that.
chrisvest
added a commit
that referenced
this pull request
Apr 7, 2022
This reverts commit 3d4ed31. Reverted because it was a backwards-compatibility work-around for 4.1 minor versions. Such hacks are unnecessary in main.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: Some integrators may choose to use custom `Http2Headers` implementations, and might not implement all methods, or might not anticipate the ways in which we'll use the methods. For instance, this was a problem that affected GRPC. Modification: To cope with this, we guard our newly added call to `Http2Headers.contains()` call with an `instanceof` check to see if we're familiar with the implementation, and fall back to checking the direct accessor methods if not. Result: Avoid breaking those who wish to use old versions of GRPC with newer versions of Netty, or situations like that.
franz1981
pushed a commit
to franz1981/netty
that referenced
this pull request
Aug 22, 2022
Motivation: Some integrators may choose to use custom `Http2Headers` implementations, and might not implement all methods, or might not anticipate the ways in which we'll use the methods. For instance, this was a problem that affected GRPC. Modification: To cope with this, we guard our newly added call to `Http2Headers.contains()` call with an `instanceof` check to see if we're familiar with the implementation, and fall back to checking the direct accessor methods if not. Result: Avoid breaking those who wish to use old versions of GRPC with newer versions of Netty, or situations like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cope with misbehaving
Http2HeadersimplementationsMotivation:
Some integrators may choose to use custom
Http2Headersimplementations, and might not implement all methods, or might not anticipate the ways in which we'll use the methods.For instance, this was a problem that affected GRPC.
Modification:
To cope with this, we guard our newly added call to
Http2Headers.contains()call with aninstanceofcheck to see if we're familiar with the implementation, and fall back to checking the direct accessor methods if not.Result:
Avoid breaking those who wish to use old versions of GRPC with newer versions of Netty, or situations like that.