Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should move from long to byte padding for False Sharing protection #12312

Open
franz1981 opened this issue Apr 19, 2022 · 2 comments
Open

We should move from long to byte padding for False Sharing protection #12312

franz1981 opened this issue Apr 19, 2022 · 2 comments
Labels
cleanup needs_backport netty5

Comments

@franz1981
Copy link
Contributor

We should use byte fields for padding to avoid upcoming false sharing problem in JDK 15+ where field ordering has changed
@normanmaurer
Copy link
Member

@franz1981 want to give it a spin ?

@chrisvest
Copy link
Contributor

In the main branch we've currently removed the padding from InternalThreadLocalMap. There was a TODO that it hadn't been tested if it actually helped or not, so if we add padding back then I think we should also be able to show that it's an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup needs_backport netty5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisvest @normanmaurer @franz1981