Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOME on a burst of datagram packets #1486

Closed
trustin opened this issue Jun 25, 2013 · 0 comments
Closed

OOME on a burst of datagram packets #1486

trustin opened this issue Jun 25, 2013 · 0 comments
Assignees
@trustin
Labels
defect
Milestone
4.0.0.CR7

Comments

@trustin
Copy link
Member

trustin commented Jun 25, 2013

NioMessageUnsafe.read() reads as many messages as possible. When a peer sends a lot of messages and NioMessageUnsafe.read() keeps reading them into a MessageList, it can end up with an OutOfMemoryError.

We need an additional configuration parameter called 'maxMessagesPerReadto limit the number of messages in aMessageList`.

Reported by @dantran
@ghost ghost assigned trustin Jun 25, 2013
trustin added a commit that referenced this issue Jun 25, 2013
@trustin
Make NioByteUnsafe.read() respect ChannelConfig.maxMessagesPerRead an…
1f27c3b 
…d adjust the default from 16 to 1

- Fixes #1486
- Decreased the default from 16 to 1 because unnecessary extra read on req-res protocols results in lower throughput due to extra syscalls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trustin trustin

Labels
defect
Projects
None yet
Milestone
4.0.0.CR7
Development

No branches or pull requests
1 participant
@trustin