Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2 RST_STREAM frame for an IDLE stream should result in connection error #3573

Closed
Scottmitch opened this issue Apr 3, 2015 · 1 comment
Closed

HTTP/2 RST_STREAM frame for an IDLE stream should result in connection error #3573

Scottmitch opened this issue Apr 3, 2015 · 1 comment
Assignees
@Scottmitch
Labels
defect
Milestone
4.1.0.Beta5

Comments

@Scottmitch
Copy link
Member

http://http2.github.io/http2-spec/index.html#RST_STREAM

RST_STREAM frames MUST NOT be sent for a stream in the "idle" state. If a RST_STREAM frame identifying an idle stream is received, the recipient MUST treat this as a connection error (Section 5.4.1) of type PROTOCOL_ERROR.
@Scottmitch Scottmitch self-assigned this Apr 3, 2015
@Scottmitch Scottmitch added this to the 4.1.0.Beta5 milestone Apr 3, 2015
@Scottmitch Scottmitch changed the title HTTP/2 RST_STREAM frame for an IDLE should result in connection error HTTP/2 RST_STREAM frame for an IDLE stream should result in connection error Apr 3, 2015
@Scottmitch
Copy link
Member Author

PR pending for this....

Scottmitch added a commit to Scottmitch/netty that referenced this issue Apr 3, 2015
@Scottmitch
HTTP/2 RST_STREAM in IDLE
1cc4b2c 
Motivation:
The spec requires that a RST_STREAM received on an IDLE stream results in a connection error. This is not happening.

Modifications:
Check for this condition when a RST_STREAM is received in DefaultHttp2ConnectionDecoder.

Result:
More spec compliant.  Fixes netty#3573.
@Scottmitch Scottmitch mentioned this issue Apr 3, 2015
Closed
Scottmitch added a commit that referenced this issue Apr 3, 2015
@Scottmitch
HTTP/2 RST_STREAM in IDLE
9517edd 
Motivation:
The spec requires that a RST_STREAM received on an IDLE stream results in a connection error. This is not happening.

Modifications:
Check for this condition when a RST_STREAM is received in DefaultHttp2ConnectionDecoder.

Result:
More spec compliant.  Fixes #3573.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmitch Scottmitch

Labels
defect
Projects
None yet
Milestone
4.1.0.Beta5
Development

Successfully merging a pull request may close this issue.

HTTP/2 RST_STREAM in IDLE Scottmitch/netty
1 participant
@Scottmitch