DefaultHttp2FrameWriter.writeGoAway leak #5850
Labels
Comments
|
number of leak detector records increased in #5849 so the leak report will be more helpful in the future |
|
Seen again while building PR #6009 on build https://garage.netty.io/teamcity/viewLog.html?buildId=13740&buildTypeId=pulls_netty&tab=buildLog |
|
The above leak trace confirms that release responsibility is on |
|
Observed while building PR #6417 more details at https://garage.netty.io/teamcity/viewLog.html?buildId=17155&buildTypeId=pulls_netty&guest=1 |
Scottmitch
added a commit
to Scottmitch/netty
that referenced
this issue
Feb 20, 2017
Motivation: Some unit HTTP/2 unit tests use LocalChannel. LocalChannel's doClose method will ensure any pending items in the queue will be released, but it may execute a Runnable on the peer's EventLoop to ensure the peer's queue is also cleaned up. The HTTP/2 unit tests close the event loop groups with no wait time so that unit tests will execute quickly, but if the doClose Runnable is in the EventLoop's queue it will not run and thus the items in the queue will not be released. Modifications: - Ensure all HTTP/2 unit tests which use LocalChannel wait for both client and server channels to be closed before closing the EventLoop. Result: Related to netty#5850.
Scottmitch
added a commit
that referenced
this issue
Feb 20, 2017
Motivation: Some unit HTTP/2 unit tests use LocalChannel. LocalChannel's doClose method will ensure any pending items in the queue will be released, but it may execute a Runnable on the peer's EventLoop to ensure the peer's queue is also cleaned up. The HTTP/2 unit tests close the event loop groups with no wait time so that unit tests will execute quickly, but if the doClose Runnable is in the EventLoop's queue it will not run and thus the items in the queue will not be released. Modifications: - Ensure all HTTP/2 unit tests which use LocalChannel wait for both client and server channels to be closed before closing the EventLoop. Result: Related to #5850.
|
PR #6422 hopefully addressed this. We can re-open later if not. We will have to be careful in other unit tests which have the same behavior (closing the EventLoop immediately without waiting to drain tasks). |
liuzhengyang
pushed a commit
to liuzhengyang/netty
that referenced
this issue
Sep 10, 2017
Motivation: Some unit HTTP/2 unit tests use LocalChannel. LocalChannel's doClose method will ensure any pending items in the queue will be released, but it may execute a Runnable on the peer's EventLoop to ensure the peer's queue is also cleaned up. The HTTP/2 unit tests close the event loop groups with no wait time so that unit tests will execute quickly, but if the doClose Runnable is in the EventLoop's queue it will not run and thus the items in the queue will not be released. Modifications: - Ensure all HTTP/2 unit tests which use LocalChannel wait for both client and server channels to be closed before closing the EventLoop. Result: Related to netty#5850.
kiril-me
pushed a commit
to kiril-me/netty
that referenced
this issue
Feb 28, 2018
Motivation: Some unit HTTP/2 unit tests use LocalChannel. LocalChannel's doClose method will ensure any pending items in the queue will be released, but it may execute a Runnable on the peer's EventLoop to ensure the peer's queue is also cleaned up. The HTTP/2 unit tests close the event loop groups with no wait time so that unit tests will execute quickly, but if the doClose Runnable is in the EventLoop's queue it will not run and thus the items in the queue will not be released. Modifications: - Ensure all HTTP/2 unit tests which use LocalChannel wait for both client and server channels to be closed before closing the EventLoop. Result: Related to netty#5850.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: