Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketClientHandshaker is broken. #661

Closed
trustin opened this issue Oct 16, 2012 · 0 comments
Closed

WebSocketClientHandshaker is broken. #661

trustin opened this issue Oct 16, 2012 · 0 comments
Assignees
@trustin
Labels
defect
Milestone
4.0.0.Alpha6

Comments

@trustin
Copy link
Member

trustin commented Oct 16, 2012

The WebSocket client example does not work as reported in #473. It turns out that the WebSocketClientHandshaker removes HttpRequestDecoder too soon. Also, the example itself sends the frame too soon.
@ghost ghost assigned trustin Oct 16, 2012
trustin added a commit that referenced this issue Oct 16, 2012
@trustin
[#661] WebSocketClientHandshaker is broken.
a6c4f65 
- Remove HttpRequestEncoder after handshaking is complete
- Fix a bug in the WebSocket client example where it sends a frame even before handshake is complete
@trustin trustin closed this as completed Oct 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trustin trustin

Labels
defect
Projects
None yet
Milestone
4.0.0.Alpha6
Development

No branches or pull requests
1 participant
@trustin