Some small improvements #11564
Merged
Some small improvements #11564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiteshKant
approved these changes
Aug 9, 2021
|
Thanks a lot @skyguard1 |
|
@NiteshKant It is my pleasure |
|
@NiteshKant Could you please re-run ci build? Thanks |
|
@skyguard1 Try rebasing. |
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
skyguard1
force-pushed
the
map_number_improve
branch
from
c431a8b
to
10276ce
Compare
chrisvest
pushed a commit
that referenced
this pull request
Aug 11, 2021
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some small improvements
Modification:
1.The minimum or the maximum of two numbers can be calculated by means of
Math.max()orMath.min()instead of doing it manually.2.Simplify the judgment of size
3.When the collection is initialized, specify the initial value of the collection.
Result:
The code is more efficient than the original implementation