Allow ThreadNameDeterminer everywhere. #1176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find a couple of places where threads are created but no ThreadNameDeterminer can be passed in to control the name of the threads created. Keep all existing c'tors for backwards compatibility.
|
Thanks! Merged via 7013315. |
ghost
assigned
SergeyMakarenko
pushed a commit
to facebookarchive/swift
that referenced
this pull request
Sep 28, 2016
- allow setting a name prefix for the threads by calling setName() on the NettyClientConfigBuilder - make netty actually name the threads in the boss and worker pool correctly by passing a ThreadNameDeterminer in. Setting the name of the timer thread will only work after - netty/netty#1176 was applied - the next version of netty gets released with this pull request applied - the line this.hashedWheelTimer = new HashedWheelTimer(renamingDaemonThreadFactory(prefix + "-timer-%s")); is replaced by this.hashedWheelTimer = new HashedWheelTimer(renamingDaemonThreadFactory(prefix + "-timer-%s"), ThreadNameDeterminer.CURRENT);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find a couple of places where threads are created but no
ThreadNameDeterminer can be passed in to control the name of the
threads created. Keep all existing c'tors for backwards compatibility.