Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::env::home_dir is deprecated since Rust version 1.29.0 #3

Closed
NickHackman opened this issue May 19, 2019 · 2 comments
Closed

std::env::home_dir is deprecated since Rust version 1.29.0 #3

NickHackman opened this issue May 19, 2019 · 2 comments

Comments

@NickHackman
Copy link
Contributor

In Rust version 1.29.0 the std::env::home_dir function used in shellexpand was deprecated and in the documentation it's said to use dirs which implements a platform agnostic way to get the current user's home directory as an alternative.

@NickHackman NickHackman changed the title std::env::home_dir is deprecated since Rust version 1.29.0 std::env::home_dir is deprecated since Rust version 1.29.0 May 19, 2019
naufraghi added a commit to naufraghi/nushell that referenced this issue Dec 13, 2019
Add tests for ~tilde expansion:

- test that "~" is expanded (no more "~" in output)
- ensure that "1~1" is not expanded to "1/home/user1" as it was
  before

Fixes nushell#972

Note: the first test does not check the literal expansion because
the path on Windows is expanded as a Linux path, but the correct
expansion may come for free once `shellexpand` will use the `dirs`
crate too (netvl/shellexpand#3).
@naufraghi
Copy link

Closed by #4 ?

@netvl
Copy link
Owner

netvl commented Dec 22, 2019

Yup, thanks!

@netvl netvl closed this as completed Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants