Expand tilde as home in external commands #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
naufraghi
force-pushed
the
issues-972-expand-tilde-as-home-in-external-commands
branch
from
aafa084
to
eab2e95
Compare
Add tests for ~tilde expansion: - test that "~" is expanded (no more "~" in output) - ensure that "1~1" is not expanded to "1/home/user1" as it was before Fixes nushell#972 Note: the first test does not check the literal expansion because the path on Windows is expanded as a Linux path, but the correct expansion may come for free once `shellexpand` will use the `dirs` crate too (netvl/shellexpand#3).
naufraghi
force-pushed
the
issues-972-expand-tilde-as-home-in-external-commands
branch
from
eab2e95
to
219b7e6
Compare
naufraghi
changed the title
|
@jonathandturner this MR is ready for the first review |
|
Looks good. If they don't update "shellexpand", it looks like we could just copy the function we're using and update it to the more recent APIs. |
naufraghi
deleted the
issues-972-expand-tilde-as-home-in-external-commands
branch
bobhy
pushed a commit
to bobhy/nushell
that referenced
this pull request
Oct 22, 2023
Changed contributer book plugins chapter python examplbe shebang to be more portable. Was: #!/usr/local/bin/python3 Now: #!/usr/bin/env python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for ~tilde expansion:
before
Fixes #972
Note: the first test does not check the literal expansion because
the path on Windows is expanded as a Linux path, but the correct
expansion may come for free once
shellexpandwill use thedirscrate too (netvl/shellexpand#3).