Skip to content

Commit

Permalink
Merge pull request #981 from fabratu/20220819_fix_gha_notebooks
Browse files Browse the repository at this point in the history
GHA: Fix errors for notebook tests and activate error output on std.
  • Loading branch information
fabratu committed Aug 22, 2022
2 parents 1e4b616 + 91b120e commit 6d970b9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ jobs:
cd ../..
python -m venv pyenv
. ./pyenv/Scripts/activate
pip install cython ipython jupyter
pip install cython ipython jupyter ipywidgets==7.7.1 jupyterlab-widgets==1.1.1
mkdir build && cd build
cmake -GNinja -DNETWORKIT_BUILD_TESTS=ON -DNETWORKIT_STATIC=ON -DCMAKE_BUILD_TYPE=Release -DNETWORKIT_CXX_STANDARD=${{ env.CXX_STANDARD }} -DNETWORKIT_WARNINGS=ON -DNETWORKIT_WARNINGS_AS_ERRORS=ON -DNETWORKIT_EXT_TLX=${{ env.TLX_PATH_WIN }} -DNETWORKIT_NATIVE=${{ env.NATIVE }} ..
ninja
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/scripts/full.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ pip3 install -r requirements.txt

python3 -m unittest discover -v networkit/test/

pip3 install ipycytoscape plotly seaborn
# Installing ipywidgets and jupyterlab-widgets (+ pinned versions) is temp. necessary due to incompatibility with Jupyterlab/plotly and ipywidgets>8.X
# See: https://github.com/plotly/plotly.py/issues/3686
pip3 install ipycytoscape plotly seaborn ipywidgets==7.7.1 jupyterlab-widgets==1.1.1

python3 notebooks/test_notebooks.py 'notebooks/'
1 change: 1 addition & 0 deletions notebooks/test_notebooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def run_notebook(path):
return 0
else:
print(" " + path + " test exited with errors.")
print(errors)
return 1

if __name__ == '__main__':
Expand Down

0 comments on commit 6d970b9

Please sign in to comment.