Pin clang-format version to 17 and mitigate ValueErrors #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cmds with non numeric suffices.
fabratu
force-pushed
the
20240201_fix_clang_format_no_number
branch
from
dc81cc2
to
8d22b1f
Compare
angriman
reviewed
Feb 3, 2024
|
Will squash on merge in the end. |
Co-authored-by: Eugenio Angriman <angriman.eugenio@gmail.com>
fabratu
force-pushed
the
20240201_fix_clang_format_no_number
branch
from
60d2cbc
to
7fbc8de
Compare
angriman
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for this PR:
clang-format-diff. These are now checked.