Faster Graph::transpose #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds great, Manuel! |
angriman
requested changes
Jul 29, 2019
|
Apart from a minor comment in the Python tests, LGTM. |
avdgrinten
reviewed
Jul 29, 2019
manpen
force-pushed
the
feature/FasterTranspose
branch
from
658609f
to
3e12ec4
Compare
|
Thanks for your feedback again. I'm now back from vacation and implemented your comments. |
|
Thank you, there is a conflict the the |
manpen
force-pushed
the
feature/FasterTranspose
branch
from
3e12ec4
to
32a5029
Compare
manpen
force-pushed
the
feature/FasterTranspose
branch
from
32a5029
to
73533ab
Compare
angriman
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Graph.transposefunction uses a GraphBuilder to copy the input graph into a transposed instance. By doing so it loses edge indices.The new variant use the new awesome
preallocateDirectedandaddPartial*Edgeinterface to directly create the new graph -- in parallel, without random I/O, and preserving edge ids. In one instance with ~110k nodes and ~60M edges to runtime decreased from356sto just under6s.The PR also removes the
Graph.cpp->GraphBuilder.hppdependency and adds a unit test for the Python interface.