Compile numerics #516
Merged
Compile numerics #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angriman
force-pushed
the
compile-numerics
branch
4 times, most recently
from
b917e6a
to
b5c6348
Compare
|
Updates of Clang versions should go into a separate PR (which we would merge first). |
fabratu
requested changes
Feb 19, 2021
networkit/cpp/algebraic/test/AlgebraicSpanningEdgeCentralityGTest.cpp
Outdated
Show resolved
Hide resolved
angriman
force-pushed
the
compile-numerics
branch
5 times, most recently
from
602367e
to
8f64a7f
Compare
Add numerics module to CMakeLists, fix compilation errors in the numerics module.
Fix unused parameter warning, and minor changes.
angriman
force-pushed
the
compile-numerics
branch
from
8f64a7f
to
85ad4ea
Compare
avdgrinten
requested changes
Feb 23, 2021
angriman
force-pushed
the
compile-numerics
branch
2 times, most recently
from
e63a963
to
30ed860
Compare
|
Sorry those have been introduced by mistake, the changes in |
avdgrinten
reviewed
Feb 23, 2021
|
|
||
|
|
||
| Vector LAMGGTest::randVector(count dimension, double lower, double upper) const { | ||
| Vector LAMGGTest::randVector(count dimension, double, double) const { |
There was a problem hiding this comment.
This looks suspicious. Why doesn't the function use it's arguments?
There was a problem hiding this comment.
I don't know the details about that, I just removed unused variables.
There was a problem hiding this comment.
Looks like the originally wanted functionality was removed without removing the parameters.
There was a problem hiding this comment.
Possibly. In that case, remove the parameters as well.
angriman
force-pushed
the
compile-numerics
branch
from
30ed860
to
3fbd8d8
Compare
|
Merging this early since this (mostly) only adds a new module and is needed for the new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numerics module and its tests were never compiled because
numericswas not included innetworkit/CMakeLists. This PR fixes some compilation errors in thenumericsmodule and includes it in the build and updatesgoogletest.Unfortunately,
LAMGGTestsegfaults when compiled with clang-3.8/3.8.1. As far as I see, this is due to a compiler bug. Since clang-3.8 has another bug that prevents us to generalizeCSRMatrixto store generic types (see #359), I'd suggest to move to clang-3.9.