Allow single % and integer weights with MatrixMarketReader #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relux-the-Relux
changed the title
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
e203ce4
to
91b40fd
Compare
fabratu
requested changes
Oct 7, 2022
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
0ff0224
to
3ebfa66
Compare
fabratu
requested changes
Oct 13, 2022
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
3ebfa66
to
9e7e6ab
Compare
angriman
reviewed
Oct 13, 2022
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
9e7e6ab
to
8688b2a
Compare
angriman
reviewed
Oct 19, 2022
angriman
reviewed
Oct 19, 2022
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
8688b2a
to
0b81ccf
Compare
angriman
reviewed
Oct 27, 2022
angriman
reviewed
Oct 27, 2022
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
3 times, most recently
from
faa59dc
to
dff2af7
Compare
fabratu
reviewed
Nov 4, 2022
| if (data == "integer") | ||
| WARN( | ||
| "Weights in NetworKit are stored as double precision floating point number while the given file uses integer weights.\ | ||
| This means that weights bigger than 4.5e15 the weights will be recorded imprecisely."); |
There was a problem hiding this comment.
Suggested change
| This means that weights bigger than 4.5e15 the weights will be recorded imprecisely."); | |
| This means that weights bigger than 4.5e15 will be recorded imprecisely."); |
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
9550769
to
5e73abe
Compare
fabratu
reviewed
Nov 7, 2022
| #include <networkit/io/MatrixMarketReader.hpp> | ||
|
|
||
| namespace NetworKit { | ||
|
|
||
| namespace { | ||
| static constexpr char COMMENT_CHAR = '%'; | ||
| static const std::string MAGIC = "%%matrixmarket"; | ||
| static constexpr std::string MAGIC1 = "%matrixmarket"; |
There was a problem hiding this comment.
I guess thats clear, but with C++ 17 constexpr is not supported for std::string (so we should use static const here).
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
5e73abe
to
72baab6
Compare
Relux-the-Relux
force-pushed
the
feature/improbe-matrix-reader
branch
from
72baab6
to
9b2a8ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the Matrix Market Format allows for both either a single or double
%in the first line(https://networkrepository.com/mtx-matrix-market-format.html) so I fixed it in our reader.Also currently we don't accept integer weights but integer weights and doubles would only not be able to match up for numbers larger than 2^52. Since most weights are smaller than that I think it is better if we accept the weights and just display a warning that for weights larger than 4.5*10^15 the stored weights will not match the given weights perfectly as otherwise, we're just causing an annoyance of having to go back and edit the files to say "real" instead of
integer.Lastly, I added tests for the MatrixmMarketRead as there were none.