Feat/#199 fail fast #202
Feat/#199 fail fast #202
Conversation
|
@khiftikhar Sorry to review the PR late, I am working on the release of the light platform during this weekend. For the fail-fast flag, I see you have added to the ValidationContext which is an object that carries the runtime info from one validator to another. The best place for the fail-fast flag would be the SchemaValidatorsConfig class which is designed to add more configuration flags in the future. In this way, we can keep the signature of JsonSchema and JsonSchemaFactory as config object already passed in. This will make the API static without impact current users. What do you think? Thanks a lot for your help. |
|
@stevehu I have moved the fail-fast flat to the SchemaValidatorsConfig.java now. Please take a look when you do have time. |
|
@khiftikhar It looks very good to put the fail-fast flag into the config. This also gives us an example of how to add another flag in the future. I see that you are using an exception to throw the message when fail-fast is true. Is there any other way to return the error message when it happens in any validator? For some users, the exception might be treated as an alarm. I will look into it when I complete the release. Thanks. |
|
@stevehu I had been looking into how we can stop the processing otherwise, but it did required a bit more changes into the code. I also thought to introduce a checked exception to Now, setting up this flag is a conscious decision of the user, and the documentation clearly specifies that no error message is returned, rather and exception is thrown. So it's the user's responsibility to take of it. |
…y first validation error.
khiftikhar
force-pushed
the
feat/#199-fail-fast
branch
from
5e7f6d6
to
8579314
Compare
|
@khiftikhar You are right. This might be the easiest way to stop the validators. I think we need to start working on the documentation as the library is getting more and more features. Thanks a lot for your help. |
|
@khiftikhar The 1.0.23 is released. Thanks a lot for your help. |
Adding the feature to fail-fast once the very first validation error is discovered.