Error status resulted at framework middleware handler is missing in auditInfo

[jiachen1120]

Currently, Error status resulted at framework middleware handler is missing in auditInfo. The reason of it would be that the response sending may be completed before adding the status into auditInfo. Therefore, the ExchangeCompleteListener inside the audit handler may not be able to add the error status into the auditMap.

We may need to adjust te order of codes within LightHttpHandler.setExchangeStatus() method from

default void setExchangeStatus(HttpServerExchange exchange, Status status) {
        ...
        exchange.getResponseSender().send(status.toString()); 
        ...
        Map<String, Object> auditInfo = exchange.getAttachment(AttachmentConstants.AUDIT_INFO);
        if(auditInfo == null) {
            auditInfo = new HashMap<>();
            exchange.putAttachment(AttachmentConstants.AUDIT_INFO, auditInfo); 
        }

        // save info for auditing purposes in case of an error
        if(auditOnError)
            auditInfo.put(Constants.STATUS, status);
        if(auditStackTrace) {
            auditInfo.put(Constants.STACK_TRACE, Arrays.toString(elements));
        }
    }

to

default void setExchangeStatus(HttpServerExchange exchange, Status status) {
        ...
        Map<String, Object> auditInfo = exchange.getAttachment(AttachmentConstants.AUDIT_INFO);
        if(auditInfo == null) {
            auditInfo = new HashMap<>();
            exchange.putAttachment(AttachmentConstants.AUDIT_INFO, auditInfo); 
        }

        // save info for auditing purposes in case of an error
        if(auditOnError)
            auditInfo.put(Constants.STATUS, status);
        if(auditStackTrace) {
            auditInfo.put(Constants.STACK_TRACE, Arrays.toString(elements));
        }
        exchange.getResponseSender().send(status.toString()); 
    }

To send the response after setting error status.

[stevehu]

@jiachen1120 Good catch!!! This makes perfect sense. Could submit a PR to get it fixed? Thanks.

[jiachen1120]

@stevehu Sure. Will submit a PR!

[stevehu]

Error status resulted at framework middleware handler is missing in auditInfo light-4j 1.6.x

[stevehu]

Error status resulted at framework middleware handler is missing in auditInfo light-4j master