feat(util): Add toByteBuffer overload util method to convert files. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NicholasAzar I have switched to a method inside the same class and tried to remove some other dependencies. I goal is the remove all the apache libraries in the future so that our delivery package becomes smaller. Thanks. |
|
@stevehu Oops! didn't see that there.. Thanks!! |
|
For most of APIs, the size is still around 20MB and I want to reduce it to around 10MB. This will make DevOps pipeline more efficient. It is hard and will take a long time. We will get there eventually. |
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
…bytebuffer feat(util): Add toByteBuffer overload util method to convert files.
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I think I'm going to need this util function to convert the zip file into a bytebuffer for returning it to the client.
In regards to: networknt/light-codegen#112